bpftool: Stop emitting static variables in BPF skeleton
authorAndrii Nakryiko <andrii@kernel.org>
Fri, 7 May 2021 05:41:16 +0000 (22:41 -0700)
committerAlexei Starovoitov <ast@kernel.org>
Tue, 11 May 2021 22:07:17 +0000 (15:07 -0700)
commit31332ccb756274c185cfd458b68b29a9371dceac
treea99857c0ae6b765de93e1af75a45f52f3fc4129c
parent256eab48e70c0eaf5b1b9af83c0588491986c7de
bpftool: Stop emitting static variables in BPF skeleton

As discussed in [0], stop emitting static variables in BPF skeletons to avoid
issues with name-conflicting static variables across multiple
statically-linked BPF object files.

Users using static variables to pass data between BPF programs and user-space
should do a trivial one-time switch according to the following simple rules:
  - read-only `static volatile const` variables should be converted to
    `volatile const`;
  - read/write `static volatile` variables should just drop `static volatile`
    modifiers to become global variables/symbols. To better handle older Clang
    versions, such newly converted global variables should be explicitly
    initialized with a specific value or `= 0`/`= {}`, whichever is
    appropriate.

  [0] https://lore.kernel.org/bpf/CAEf4BzZo7_r-hsNvJt3w3kyrmmBJj7ghGY8+k4nvKF0KLjma=w@mail.gmail.com/T/#m664d4b0d6b31ac8b2669360e0fc2d6962e9f5ec1

Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Link: https://lore.kernel.org/bpf/20210507054119.270888-5-andrii@kernel.org
tools/bpf/bpftool/gen.c