proc: make struct proc_dir_entry::namelen unsigned int
authorAlexey Dobriyan <adobriyan@gmail.com>
Wed, 23 Mar 2011 23:42:52 +0000 (16:42 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Thu, 24 Mar 2011 02:46:37 +0000 (19:46 -0700)
commit312ec7e50c4d3f40b3762af651d1aa79a67f556a
tree98112d9c80aacd011e313268b5f5d8caf5b5b727
parentfc3d8767b2b6de955579852d7a150f1734265eaf
proc: make struct proc_dir_entry::namelen unsigned int

1. namelen is declared "unsigned short" which hints for "maybe space savings".
   Indeed in 2.4 struct proc_dir_entry looked like:

        struct proc_dir_entry {
                unsigned short low_ino;
                unsigned short namelen;

   Now, low_ino is "unsigned int", all savings were gone for a long time.
   "struct proc_dir_entry" is not that countless to worry about it's size,
   anyway.

2. converting from unsigned short to int/unsigned int can only create
   problems, we better play it safe.

Space is not really conserved, because of natural alignment for the next
field.  sizeof(struct proc_dir_entry) remains the same.

Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
fs/proc/generic.c
include/linux/proc_fs.h