mpt3sas: Ensure the connector_name string is NUL-terminated
authorCalvin Owens <calvinowens@fb.com>
Thu, 28 Jul 2016 04:45:51 +0000 (21:45 -0700)
committerMartin K. Petersen <martin.petersen@oracle.com>
Tue, 9 Aug 2016 01:05:58 +0000 (21:05 -0400)
commit310c8e40d5cd2512b6d46177563460726cc6166a
tree294c8777c7e21c6b54e8981e4d16bbf3d6d4114d
parent29b4817d4018df78086157ea3a55c1d9424a7cfc
mpt3sas: Ensure the connector_name string is NUL-terminated

We blindly trust the hardware to give us NUL-terminated strings, which
is a bad idea because it doesn't always do that. For example:

  [  481.184784] mpt3sas_cm0:  enclosure level(0x0000), connector name(     \x3)

In this case, connector_name is four spaces. We got lucky here because
the 2nd byte beyond our character array happens to be a NUL. Fix this by
explicitly writing '\0' to the end of the string to ensure we don't run
off the edge of the world in printk().

Signed-off-by: Calvin Owens <calvinowens@fb.com>
Acked-by: Chaitra P B <chaitra.basappa@broadcom.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/mpt3sas/mpt3sas_base.h
drivers/scsi/mpt3sas/mpt3sas_scsih.c