block: Assert !bs->refcnt in bdrv_close()
authorMax Reitz <mreitz@redhat.com>
Tue, 17 May 2016 14:41:32 +0000 (16:41 +0200)
committerKevin Wolf <kwolf@redhat.com>
Wed, 25 May 2016 17:04:10 +0000 (19:04 +0200)
commit30f55fb81ff65473d673e79ca7175672e859fa2f
tree3dd6a247e3f8ee2b0c52a93f67ab9e8414f77b13
parent5b3639371c3e220b41cd2eae8c34c49ad38ef527
block: Assert !bs->refcnt in bdrv_close()

The only caller of bdrv_close() left is bdrv_delete(). We may as well
assert that, in a way (there are some things in bdrv_close() that make
more sense under that assumption, such as the call to
bdrv_release_all_dirty_bitmaps() which in turn assumes that no frozen
bitmaps are attached to the BDS).

In addition, being called only in bdrv_delete() means that we can drop
bdrv_close()'s forward declaration at the top of block.c.

Signed-off-by: Max Reitz <mreitz@redhat.com>
Reviewed-by: Alberto Garcia <berto@igalia.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
block.c