net/sched: act_pedit: Add size check for TCA_PEDIT_PARMS_EX
authorLin Ma <linma@zju.edu.cn>
Mon, 3 Jul 2023 11:08:42 +0000 (19:08 +0800)
committerPaolo Abeni <pabeni@redhat.com>
Tue, 4 Jul 2023 08:31:38 +0000 (10:31 +0200)
commit30c45b5361d39b4b793780ffac5538090b9e2eb1
tree95f2b5b0bbd2cef0e97f449bb92d39ec417f6f88
parent2c5d234d7f55e4ba7f3ee00fb9452ac7c97b4a46
net/sched: act_pedit: Add size check for TCA_PEDIT_PARMS_EX

The attribute TCA_PEDIT_PARMS_EX is not be included in pedit_policy and
one malicious user could fake a TCA_PEDIT_PARMS_EX whose length is
smaller than the intended sizeof(struct tc_pedit). Hence, the
dereference in tcf_pedit_init() could access dirty heap data.

static int tcf_pedit_init(...)
{
  // ...
  pattr = tb[TCA_PEDIT_PARMS]; // TCA_PEDIT_PARMS is included
  if (!pattr)
    pattr = tb[TCA_PEDIT_PARMS_EX]; // but this is not

  // ...
  parm = nla_data(pattr);

  index = parm->index; // parm is able to be smaller than 4 bytes
                       // and this dereference gets dirty skb_buff
                       // data created in netlink_sendmsg
}

This commit adds TCA_PEDIT_PARMS_EX length in pedit_policy which avoid
the above case, just like the TCA_PEDIT_PARMS.

Fixes: 71d0ed7079df ("net/act_pedit: Support using offset relative to the conventional network headers")
Signed-off-by: Lin Ma <linma@zju.edu.cn>
Reviewed-by: Pedro Tammela <pctammela@mojatatu.com>
Link: https://lore.kernel.org/r/20230703110842.590282-1-linma@zju.edu.cn
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
net/sched/act_pedit.c