kdb: Fix handling of kallsyms_symbol_next() return value
authorDaniel Thompson <daniel.thompson@linaro.org>
Mon, 2 Mar 2015 14:13:36 +0000 (14:13 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 14 Dec 2017 08:28:13 +0000 (09:28 +0100)
commit30b18ee253a09a36d43a1e126b124296b0d649a7
tree21d382e6ddaf3e8997ea56d4119aed66ebbd6b2c
parent4a70f07da85313aa817c0888d2b623ea30cbbbe5
kdb: Fix handling of kallsyms_symbol_next() return value

commit c07d35338081d107e57cf37572d8cc931a8e32e2 upstream.

kallsyms_symbol_next() returns a boolean (true on success). Currently
kdb_read() tests the return value with an inequality that
unconditionally evaluates to true.

This is fixed in the obvious way and, since the conditional branch is
supposed to be unreachable, we also add a WARN_ON().

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Daniel Thompson <daniel.thompson@linaro.org>
Signed-off-by: Jason Wessel <jason.wessel@windriver.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
kernel/debug/kdb/kdb_io.c