dlm: Replace all non-returning strlcpy with strscpy
authorAzeem Shaikh <azeemshaikh38@gmail.com>
Wed, 10 May 2023 22:12:37 +0000 (22:12 +0000)
committerKees Cook <keescook@chromium.org>
Mon, 22 May 2023 19:34:09 +0000 (12:34 -0700)
commit30ad0627f169f56180e668e7223eaa43aa190a75
tree91194d2e731e125d09b2af7963576f9a2db5e64b
parentdf8fc4e934c12b906d08050d7779f292b9c5c6b5
dlm: Replace all non-returning strlcpy with strscpy

strlcpy() reads the entire source buffer first.
This read may exceed the destination size limit.
This is both inefficient and can lead to linear read
overflows if a source string is not NUL-terminated [1].
In an effort to remove strlcpy() completely [2], replace
strlcpy() here with strscpy().
No return values were used, so direct replacement is safe.

[1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy
[2] https://github.com/KSPP/linux/issues/89

Signed-off-by: Azeem Shaikh <azeemshaikh38@gmail.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Kees Cook <keescook@chromium.org>
Link: https://lore.kernel.org/r/20230510221237.3509484-1-azeemshaikh38@gmail.com
fs/dlm/config.c