selinux: fix double free
authorTom Rix <trix@redhat.com>
Wed, 10 Jun 2020 21:57:13 +0000 (14:57 -0700)
committerSasha Levin <sashal@kernel.org>
Tue, 30 Jun 2020 19:38:31 +0000 (15:38 -0400)
commit30627877c2074eb6e10092f2cfe19157eea49ad2
tree88fde5a9fd6047c56fb7653bc639cf6542154613
parentd604a3a1dd82e296b9efbfe67bd3b64dbe40d8f8
selinux: fix double free

commit 65de50969a77509452ae590e9449b70a22b923bb upstream.

Clang's static analysis tool reports these double free memory errors.

security/selinux/ss/services.c:2987:4: warning: Attempt to free released memory [unix.Malloc]
                        kfree(bnames[i]);
                        ^~~~~~~~~~~~~~~~
security/selinux/ss/services.c:2990:2: warning: Attempt to free released memory [unix.Malloc]
        kfree(bvalues);
        ^~~~~~~~~~~~~~

So improve the security_get_bools error handling by freeing these variables
and setting their return pointers to NULL and the return len to 0

Cc: stable@vger.kernel.org
Signed-off-by: Tom Rix <trix@redhat.com>
Acked-by: Stephen Smalley <stephen.smalley.work@gmail.com>
Signed-off-by: Paul Moore <paul@paul-moore.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
security/selinux/ss/services.c