libbpf: Fix bail out from 'ringbuf_process_ring()' on error
authorPedro Tammela <pctammela@gmail.com>
Thu, 25 Mar 2021 15:01:15 +0000 (12:01 -0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 14 Apr 2021 06:42:00 +0000 (08:42 +0200)
commit3015db3de71545d385416a4a4e1242509343cceb
tree3b882818e2bf8373202d3318232a6220e3dd7867
parentdc195928d7e4ec7b5cfc6cd10dc4c8d87a7c72ac
libbpf: Fix bail out from 'ringbuf_process_ring()' on error

commit 6032ebb54c60cae24329f6aba3ce0c1ca8ad6abe upstream.

The current code bails out with negative and positive returns.
If the callback returns a positive return code, 'ring_buffer__consume()'
and 'ring_buffer__poll()' will return a spurious number of records
consumed, but mostly important will continue the processing loop.

This patch makes positive returns from the callback a no-op.

Fixes: bf99c936f947 ("libbpf: Add BPF ring buffer support")
Signed-off-by: Pedro Tammela <pctammela@mojatatu.com>
Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
Link: https://lore.kernel.org/bpf/20210325150115.138750-1-pctammela@mojatatu.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
tools/lib/bpf/ringbuf.c