[lldb][NFC] Refactor remaining completion logic to use CompletionRequests
authorRaphael Isemann <teemperor@gmail.com>
Thu, 15 Aug 2019 13:14:10 +0000 (13:14 +0000)
committerRaphael Isemann <teemperor@gmail.com>
Thu, 15 Aug 2019 13:14:10 +0000 (13:14 +0000)
commit2fc20f652cd848abdbfc40b6ae7fc0b0b403ea7d
tree44d036fe01586ba334cff331edceca798c93799c
parentdc23c832f4f7e5ae8204acfe800bdb611525c8bd
[lldb][NFC] Refactor remaining completion logic to use CompletionRequests

This patch moves the remaining completion functions from the
old completion API (that used several variables) to just
passing a single CompletionRequest.

This is for the most part a simple change as we just replace
the old arguments with a single CompletionRequest argument.

There are a few places where I had to create new CompletionRequests
in the called functions as CompletionRequests itself are immutable
and don't expose their internal match list anymore. This means that
if a function wanted to change the CompletionRequest or directly
access the result list, we need to work around this by creating
a new CompletionRequest and a temporary match/description list.

Preparation work for rdar://53769355

llvm-svn: 369000
lldb/include/lldb/Core/IOHandler.h
lldb/include/lldb/Expression/REPL.h
lldb/include/lldb/Host/Editline.h
lldb/include/lldb/Interpreter/CommandInterpreter.h
lldb/include/lldb/Utility/CompletionRequest.h
lldb/source/API/SBCommandInterpreter.cpp
lldb/source/Core/IOHandler.cpp
lldb/source/Expression/REPL.cpp
lldb/source/Host/common/Editline.cpp
lldb/source/Interpreter/CommandInterpreter.cpp