scsi: qedi: Replace all non-returning strlcpy with strscpy
authorAzeem Shaikh <azeemshaikh38@gmail.com>
Wed, 17 May 2023 14:35:09 +0000 (14:35 +0000)
committerKees Cook <keescook@chromium.org>
Fri, 26 May 2023 20:52:19 +0000 (13:52 -0700)
commit2f4113b330810ab71efa0bd4bbd0655154cd2a70
treeee5fa5b80356295728b46670e05d7e6dc3e00816
parent3b92d34ac06a4bb05a349641cb22373f1ae33f0b
scsi: qedi: Replace all non-returning strlcpy with strscpy

strlcpy() reads the entire source buffer first.
This read may exceed the destination size limit.
This is both inefficient and can lead to linear read
overflows if a source string is not NUL-terminated [1].
In an effort to remove strlcpy() completely [2], replace
strlcpy() here with strscpy().
No return values were used, so direct replacement is safe.

[1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy
[2] https://github.com/KSPP/linux/issues/89

Signed-off-by: Azeem Shaikh <azeemshaikh38@gmail.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Kees Cook <keescook@chromium.org>
Link: https://lore.kernel.org/r/20230517143509.1520387-1-azeemshaikh38@gmail.com
drivers/scsi/qedi/qedi_main.c