md/raid5: Convert stripe_head's "dev" to flexible array member
authorKees Cook <keescook@chromium.org>
Fri, 12 May 2023 21:22:12 +0000 (14:22 -0700)
committerKees Cook <keescook@chromium.org>
Tue, 30 May 2023 23:41:52 +0000 (16:41 -0700)
commit2f088dfc1878108748018af0d2e3748ba9eee1e9
treeb8bca628f76deb84c5e84e6c369c023d4a70ba38
parentd67790ddf0219aa0ad3e13b53ae0a7619b3425a2
md/raid5: Convert stripe_head's "dev" to flexible array member

Replace old-style 1-element array of "dev" in struct stripe_head with
modern C99 flexible array. In the future, we can additionally annotate
it with the run-time size, found in the "disks" member.

Cc: Song Liu <song@kernel.org>
Cc: linux-raid@vger.kernel.org
Reviewed-by: Christoph Hellwig <hch@lst.de>
Acked-by: Song Liu <song@kernel.org>
Signed-off-by: Kees Cook <keescook@chromium.org>
Link: https://lore.kernel.org/lkml/20230522212114.gonna.589-kees@kernel.org/
---
It looks like this memory calculation:

        memory = conf->min_nr_stripes * (sizeof(struct stripe_head) +
                 max_disks * ((sizeof(struct bio) + PAGE_SIZE))) / 1024;

... was already buggy (i.e. it included the single "dev" bytes in the
result). However, I'm not entirely sure if that is the right analysis,
since "dev" is not related to struct bio nor PAGE_SIZE?
drivers/md/raid5.c
drivers/md/raid5.h