tracing: Don't use out-of-sync va_list in event printing
authorNikita Yushchenko <nikita.yushchenko@virtuozzo.com>
Thu, 18 Nov 2021 14:55:16 +0000 (17:55 +0300)
committerSteven Rostedt (VMware) <rostedt@goodmis.org>
Fri, 19 Nov 2021 02:10:18 +0000 (21:10 -0500)
commit2ef75e9bd2c998f1c6f6f23a3744136105ddefd5
tree4d410a3f4373de3ddd33f137f1f3a8d94609e2c3
parentc4c1dbcc09e723295969a62aff401815b7ee15f4
tracing: Don't use out-of-sync va_list in event printing

If trace_seq becomes full, trace_seq_vprintf() no longer consumes
arguments from va_list, making va_list out of sync with format
processing by trace_check_vprintf().

This causes va_arg() in trace_check_vprintf() to return wrong
positional argument, which results into a WARN_ON_ONCE() hit.

ftrace_stress_test from LTP triggers this situation.

Fix it by explicitly avoiding further use if va_list at the point
when it's consistency can no longer be guaranteed.

Link: https://lkml.kernel.org/r/20211118145516.13219-1-nikita.yushchenko@virtuozzo.com
Signed-off-by: Nikita Yushchenko <nikita.yushchenko@virtuozzo.com>
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
kernel/trace/trace.c