[clangd] Remove didOpen extraFlags extension.
authorSam McCall <sam.mccall@gmail.com>
Fri, 2 Nov 2018 13:06:55 +0000 (13:06 +0000)
committerSam McCall <sam.mccall@gmail.com>
Fri, 2 Nov 2018 13:06:55 +0000 (13:06 +0000)
commit2eb6b4038a2a66a413efce8892d4c82ca6762e13
treed54502db574743604a67a857b474b7ec21dde2ac
parent3fd25fcf36aaf7945f1669bce4f5aa5c9bf36bb6
[clangd] Remove didOpen extraFlags extension.

Summary:
This was added in D34947 to support YCM, but YCM actually provides *all* args,
and this was never actually used.
Meanwhile, we grew another extension that allows specifying all args.

I did find one user of this extension: https://github.com/thomasjo/atom-ide-cpp.
I'll reach out, there are multiple good alternatives:
 - compile_commands.txt can serve the same purpose as .clang_complete there
 - we can add an extension to support setting the fallback command

Reviewers: ilya-biryukov

Subscribers: ioeric, MaskRay, jkorous, arphaman, kadircet, cfe-commits

Differential Revision: https://reviews.llvm.org/D53641

llvm-svn: 345969
clang-tools-extra/clangd/ClangdLSPServer.cpp
clang-tools-extra/clangd/ClangdLSPServer.h
clang-tools-extra/clangd/GlobalCompilationDatabase.cpp
clang-tools-extra/clangd/GlobalCompilationDatabase.h
clang-tools-extra/clangd/Protocol.cpp
clang-tools-extra/clangd/Protocol.h
clang-tools-extra/test/clangd/extra-flags.test [deleted file]