Revert "Fix a race condition between "ephemeral watchpoint disable/enable" and contin...
authorPavel Labath <labath@google.com>
Fri, 21 Oct 2016 10:52:11 +0000 (10:52 +0000)
committerPavel Labath <labath@google.com>
Fri, 21 Oct 2016 10:52:11 +0000 (10:52 +0000)
commit2e8fe804475feab86bbf857b0475d36b56460c19
tree8fc4fe0d9a54351c010d3943e3b4b6c1b284f0b7
parentf447fbf913dcdbe651764e452c8abc1d32656e46
Revert "Fix a race condition between "ephemeral watchpoint disable/enable" and continue in commands."

This reverts commit r284795, as it breaks watchpoint handling on arm (and
presumable all architectures that report watchpoint hits without executing the
tripping instruction).

There seems to be something fundamentally wrong with this patch: it uses
process_sp->AddPreResumeAction to re-enable the watchpoint, but the whole point
of the step-over-watchpoint logic (which AFAIK is the only user of this class) is
to disable the watchpoint *after* we resume to do the single step.

I have no idea how to fix this except by reverting the offending patch.

llvm-svn: 284817
lldb/packages/Python/lldbsuite/test/functionalities/watchpoint/watchpoint_commands/command/TestWatchpointCommandPython.py
lldb/source/Breakpoint/Watchpoint.cpp
lldb/source/Target/StopInfo.cpp