nvme-pci: factor out a nvme_pci_alloc_dev helper
authorChristoph Hellwig <hch@lst.de>
Tue, 8 Nov 2022 08:44:00 +0000 (09:44 +0100)
committerChristoph Hellwig <hch@lst.de>
Tue, 15 Nov 2022 09:56:09 +0000 (10:56 +0100)
commit2e87570be9d2746e7c4e7ab1cc18fd3ca7de2768
tree2e71d4b346cab058efa05cdc5fc256f8640c4177
parent081a7d958ce4b65f9aab6e70e65b0b2e0b92297c
nvme-pci: factor out a nvme_pci_alloc_dev helper

Add a helper that allocates the nvme_dev structure up to the point where
we can call nvme_init_ctrl.  This pairs with the free_ctrl method and can
thus be used to cleanup the teardown path and make it more symmetric.

Note that this now calls nvme_init_ctrl a lot earlier during probing,
which also means the per-controller character device shows up earlier.
Due to the controller state no commnds can be send on it, but it might
make sense to delay the cdev registration until nvme_init_ctrl_finish.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Keith Busch <kbusch@kernel.org>
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
Tested-by Gerd Bayer <gbayer@linxu.ibm.com>
drivers/nvme/host/pci.c