staging: comedi: dt282x: dt282x_ai_insn_read() always fails
authorDan Carpenter <dan.carpenter@oracle.com>
Tue, 20 Aug 2013 08:57:35 +0000 (11:57 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 27 Sep 2013 00:21:38 +0000 (17:21 -0700)
commit2e5ca3973e694ba0bf117323a8501cfc982de165
treeb86e78e53c9a3ba84e7a66fb6a47b8b5e2485338
parent6bcda1654a21aef4165158ae81e6e4ea3d137c06
staging: comedi: dt282x: dt282x_ai_insn_read() always fails

commit 2c4283ca7cdcc6605859c836fc536fcd83a4525f upstream.

In dt282x_ai_insn_read() we call this macro like:
wait_for(!mux_busy(), comedi_error(dev, "timeout\n"); return -ETIME;);
Because the if statement doesn't have curly braces it means we always
return -ETIME and the function never succeeds.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/comedi/drivers/dt282x.c