libgomp testsuite: Don't amend 'LD_LIBRARY_PATH' for system-provided HSA Runtime...
authorThomas Schwinge <thomas@codesourcery.com>
Wed, 6 Apr 2022 08:39:56 +0000 (10:39 +0200)
committerThomas Schwinge <thomas@codesourcery.com>
Wed, 11 May 2022 12:24:21 +0000 (14:24 +0200)
commit2e309a4eff80e55b53d32d26926a2a94eabfea21
tree0c05f284b58dcea83b4e6603443b74edce003823
parent8fa689767a8a55c889683d178ae3a003ec689927
libgomp testsuite: Don't amend 'LD_LIBRARY_PATH' for system-provided HSA Runtime library

This is only active if GCC is 'configure'd with '--with-hsa-runtime=[...]' or
'--with-hsa-runtime-lib=[...]' -- which nobody really is doing, as far as I can
tell.

'libgomp/testsuite/lib/libgomp.exp:libgomp_init' states:

    # For build-tree testing, also consider the library paths used for builing.
    # For installed testing, we assume all that to be provided in the sysroot.
    if { $blddir != "" } {
        [...]
        global hsa_runtime_lib
        if { $hsa_runtime_lib != "" } {
            append always_ld_library_path ":$hsa_runtime_lib"
        }
    }

However, the libgomp GCN plugin is unconditionally built against the
GCC-shipped 'include/hsa*.h' header files, and at run time does
'dlopen("libhsa-runtime64.so.1")', so there is no system-provided HSA Runtime
library "used for builing".  It thus doesn't make sense to amend
'LD_LIBRARY_PATH' for system-provided HSA Runtime library.

libgomp/
* testsuite/lib/libgomp.exp (libgomp_init): Don't
'append always_ld_library_path ":$hsa_runtime_lib"'.
* testsuite/libgomp-test-support.exp.in (hsa_runtime_lib): Don't set.
libgomp/testsuite/lib/libgomp.exp
libgomp/testsuite/libgomp-test-support.exp.in