arm64: mte: Ensure TIF_MTE_ASYNC_FAULT is set atomically
authorCatalin Marinas <catalin.marinas@arm.com>
Fri, 9 Apr 2021 17:37:10 +0000 (18:37 +0100)
committerWill Deacon <will@kernel.org>
Mon, 12 Apr 2021 12:38:45 +0000 (13:38 +0100)
commit2decad92f4731fac9755a083fcfefa66edb7d67d
tree954e29baf4bce155777502117ff6cb26272ea2e4
parent185f2e5f51c2029efd9dd26cceb968a44fe053c6
arm64: mte: Ensure TIF_MTE_ASYNC_FAULT is set atomically

The entry from EL0 code checks the TFSRE0_EL1 register for any
asynchronous tag check faults in user space and sets the
TIF_MTE_ASYNC_FAULT flag. This is not done atomically, potentially
racing with another CPU calling set_tsk_thread_flag().

Replace the non-atomic ORR+STR with an STSET instruction. While STSET
requires ARMv8.1 and an assembler that understands LSE atomics, the MTE
feature is part of ARMv8.5 and already requires an updated assembler.

Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
Fixes: 637ec831ea4f ("arm64: mte: Handle synchronous and asynchronous tag check faults")
Cc: <stable@vger.kernel.org> # 5.10.x
Reported-by: Will Deacon <will@kernel.org>
Cc: Will Deacon <will@kernel.org>
Cc: Vincenzo Frascino <vincenzo.frascino@arm.com>
Cc: Mark Rutland <mark.rutland@arm.com>
Link: https://lore.kernel.org/r/20210409173710.18582-1-catalin.marinas@arm.com
Signed-off-by: Will Deacon <will@kernel.org>
arch/arm64/Kconfig
arch/arm64/kernel/entry.S