ata: libahci: Correct setting of DEVSLP register
authorSrinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Mon, 2 Jul 2018 19:01:53 +0000 (12:01 -0700)
committerTejun Heo <tj@kernel.org>
Mon, 30 Jul 2018 17:32:51 +0000 (10:32 -0700)
commit2dbb3ec29a6c069035857a2fc4c24e80e5dfe3cc
tree30158080c983b8157c4782fbd25f25809e076080
parentb1a9585cc396cac5a9e5a09b2721f3b8568e62d0
ata: libahci: Correct setting of DEVSLP register

We have seen that on some platforms, SATA device never show any DEVSLP
residency. This prevent power gating of SATA IP, which prevent system
to transition to low power mode in systems with SLP_S0 aka modern
standby systems. The PHY logic is off only in DEVSLP not in slumber.
Reference:
https://www.intel.com/content/dam/www/public/us/en/documents/datasheets
/332995-skylake-i-o-platform-datasheet-volume-1.pdf
Section 28.7.6.1

Here driver is trying to do read-modify-write the devslp register. But
not resetting the bits for which this driver will modify values (DITO,
MDAT and DETO). So simply reset those bits before updating to new values.

Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Reviewed-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
drivers/ata/libahci.c