Address more PR feedback and additional fixes
authorStephen Toub <stoub@microsoft.com>
Wed, 6 Jul 2016 15:21:15 +0000 (11:21 -0400)
committerStephen Toub <stoub@microsoft.com>
Wed, 6 Jul 2016 21:55:54 +0000 (17:55 -0400)
commit2d87dd461d9cb1955cd2862621cbe7a3f37f2807
treefce5aad1814b45fb3ac0987c20c443d6dbc4c035
parent53803e9a0330045d8be9294dee225fb757b3dd6d
Address more PR feedback and additional fixes

Main changes:
- Rename Environment Windows files to .Win32.cs and .WinRT.cs
- Refactor environment variable functions to help with tree shaking
- Fix environ access on macOS
- Remove direct Environment dependency from System.Diagnostics.Debug causing ambiguity

Commit migrated from https://github.com/dotnet/corefx/commit/8ea801cdd2bc2d661b78e300064b43c8733b0471
12 files changed:
src/libraries/Native/Common/pal_config.h.in
src/libraries/Native/System.Native/pal_process.cpp
src/libraries/Native/System.Native/pal_uid.cpp
src/libraries/Native/configure.cmake
src/libraries/System.Diagnostics.Debug/tests/DebugTests.cs
src/libraries/System.Diagnostics.Tracing/tests/BasicEventSourceTest/TestsManifestNegative.cs
src/libraries/System.Runtime.Extensions/src/System.Runtime.Extensions.csproj
src/libraries/System.Runtime.Extensions/src/System/Environment.Unix.cs
src/libraries/System.Runtime.Extensions/src/System/Environment.Win32.cs [moved from src/libraries/System.Runtime.Extensions/src/System/Environment.CoreCLR.cs with 78% similarity]
src/libraries/System.Runtime.Extensions/src/System/Environment.WinRT.cs [moved from src/libraries/System.Runtime.Extensions/src/System/Environment.NETNative.cs with 66% similarity]
src/libraries/System.Runtime.Extensions/src/System/Environment.cs
src/libraries/System.Runtime.Extensions/tests/System/Environment.SetEnvironmentVariable.cs