tcmu: reconfigure netlink attr changes
authorMike Christie <mchristi@redhat.com>
Mon, 12 Jun 2017 06:34:28 +0000 (01:34 -0500)
committerNicholas Bellinger <nab@linux-iscsi.org>
Fri, 7 Jul 2017 06:11:36 +0000 (23:11 -0700)
commit2d76443e02f260d7a5bd0ede1851ae5534f0c68d
tree537aa19cfd1d41b92a2fbf9e354c1b3258208262
parent5f572526a18418258bfa137e3353656c25439500
tcmu: reconfigure netlink attr changes

1. TCMU_ATTR_TYPE is too generic when it describes only the
reconfiguration type, so rename to TCMU_ATTR_RECONFIG_TYPE.

2. Only return the reconfig type when it is a
TCMU_CMD_RECONFIG_DEVICE command.

3. CONFIG_* type is not needed. We can pass the value along with an
ATTR to userspace, so it does not need to read sysfs/configfs.

4. Fix leak in tcmu_dev_path_store and rename to dev_config to
reflect it is more than just a path that can be changed.

6. Don't update kernel struct value if netlink sending fails.

Signed-off-by: Mike Christie <mchristi@redhat.com>
Reviewed-by: "Bryant G. Ly" <bryantly@linux.vnet.ibm.com>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
drivers/target/target_core_user.c
include/uapi/linux/target_core_user.h