c++: ICE when shortening right shift [PR94955]
authorMarek Polacek <polacek@redhat.com>
Wed, 6 May 2020 19:53:33 +0000 (15:53 -0400)
committerMarek Polacek <polacek@redhat.com>
Mon, 18 May 2020 23:01:54 +0000 (19:01 -0400)
commit2d4e1e144c25e526e4f668be5a0bc10d0c1c738c
tree1e73b7bcfa85d209cf4dcd1ada19fb46f881b49a
parentbf732686c0b9c42a2fe119db774c5a65e5a97174
c++: ICE when shortening right shift [PR94955]

Since r10-6527 fold_for_warn calls maybe_constant_value, which means it
can fold more than it previously could.  In this testcase it means that
cp_build_binary_op/RSHIFT_EXPR set short_shift because now we were able
to fold op1 to an INTEGER_CST.  But then when actually performing the
shortening we crashed because cp_fold_rvalue wasn't able to fold as much
as f_f_w and so tree_int_cst_sgn crashed on a NOP_EXPR.  Therefore the
calls should probably match.

PR c++/94955
* typeck.c (cp_build_binary_op): Use fold_for_warn instead of
cp_fold_rvalue.

* g++.dg/cpp0x/constexpr-shift2.C: New test.
gcc/cp/ChangeLog
gcc/cp/typeck.c
gcc/testsuite/ChangeLog
gcc/testsuite/g++.dg/cpp0x/constexpr-shift2.C [new file with mode: 0644]