st: Destroy st_index_idr on module exit
authorJohannes Thumshirn <jthumshirn@suse.de>
Wed, 8 Jul 2015 15:24:01 +0000 (17:24 +0200)
committerJames Bottomley <JBottomley@Odin.com>
Wed, 26 Aug 2015 14:45:25 +0000 (07:45 -0700)
commit2d3a5d215e24d9bfb822ae82c6c2c5d333be076d
tree88a843a1b0f4972b39f830a9f45b9c7e04791dda
parentda0dc9fb4e6b0ad5a947c27a3c48985f6a2377eb
st: Destroy st_index_idr on module exit

Destroy st_index_idr on module exit, reclaiming the allocated memory.

This was detected by the following semantic patch (written by Luis Rodriguez
<mcgrof@suse.com>)
<SmPL>
@ defines_module_init @
declarer name module_init, module_exit;
declarer name DEFINE_IDR;
identifier init;
@@

module_init(init);

@ defines_module_exit @
identifier exit;
@@

module_exit(exit);

@ declares_idr depends on defines_module_init && defines_module_exit @
identifier idr;
@@

DEFINE_IDR(idr);

@ on_exit_calls_destroy depends on declares_idr && defines_module_exit @
identifier declares_idr.idr, defines_module_exit.exit;
@@

exit(void)
{
 ...
 idr_destroy(&idr);
 ...
}

@ missing_module_idr_destroy depends on declares_idr && defines_module_exit && !on_exit_calls_destroy @
identifier declares_idr.idr, defines_module_exit.exit;
@@

exit(void)
{
 ...
 +idr_destroy(&idr);
}
</SmPL>

Signed-off-by: Johannes Thumshirn <jthumshirn@suse.de>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Acked-by: Kai Mäkisara <kai.makisara@kolumbus.fi>
Signed-off-by: James Bottomley <JBottomley@Odin.com>
drivers/scsi/st.c