early init: fix error handling when opening /dev/console
authorLinus Torvalds <torvalds@linux-foundation.org>
Tue, 17 Dec 2019 21:10:11 +0000 (13:10 -0800)
committerLinus Torvalds <torvalds@linux-foundation.org>
Tue, 17 Dec 2019 21:10:11 +0000 (13:10 -0800)
commit2d3145f8d2809592ef803a30c8a342b5a9e2de9a
tree6bc66d13f1815e181d3fac34e13b524a769940e0
parent58d90a04bdcc28e1b34251f4d9c1c4d39d4bba69
early init: fix error handling when opening /dev/console

The comment says "this should never fail", but it definitely can fail
when you have odd initial boot filesystems, or kernel configurations.

So get the error handling right: filp_open() returns an error pointer.

Reported-by: Jesse Barnes <jsbarnes@google.com>
Reported-by: youling 257 <youling257@gmail.com>
Fixes: 8243186f0cc7 ("fs: remove ksys_dup()")
Cc: Dominik Brodowski <linux@dominikbrodowski.net>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
init/main.c