selftests/sgx: Fix NULL-pointer-dereference upon early test failure
authorReinette Chatre <reinette.chatre@intel.com>
Tue, 8 Feb 2022 21:48:39 +0000 (13:48 -0800)
committerDave Hansen <dave.hansen@linux.intel.com>
Fri, 11 Feb 2022 21:52:47 +0000 (13:52 -0800)
commit2d03861e0d1d1ee81efc59338101cdd86a7474f6
tree8d9a984fae6982b7d3d5362121115a34a7edf405
parentdfd42facf1e4ada021b939b4e19c935dcdd55566
selftests/sgx: Fix NULL-pointer-dereference upon early test failure

== Background ==

The SGX selftests track parts of the enclave binaries in an array:
encl->segment_tbl[]. That array is dynamically allocated early
(but not first) in the test's lifetime. The array is referenced
at the end of the test in encl_delete().

== Problem ==

encl->segment_tbl[] can be NULL if the test fails before its
allocation. That leads to a NULL-pointer-dereference in encl_delete().
This is triggered during early failures of the selftest like if the
enclave binary ("test_encl.elf") is deleted.

== Solution ==

Ensure encl->segment_tbl[] is valid before attempting to access
its members. The offset with which it is accessed, encl->nr_segments,
is initialized before encl->segment_tbl[] and thus considered valid
to use after the encl->segment_tbl[] check succeeds.

Fixes: 3200505d4de6 ("selftests/sgx: Create a heap for the test enclave")
Signed-off-by: Reinette Chatre <reinette.chatre@intel.com>
Signed-off-by: Dave Hansen <dave.hansen@linux.intel.com>
Acked-by: Shuah Khan <skhan@linuxfoundation.org>
Link: https://lkml.kernel.org/r/90a31dfd640ea756fa324712e7cbab4a90fa7518.1644355600.git.reinette.chatre@intel.com
tools/testing/selftests/sgx/load.c