c++: inlining explicit instantiations [PR104539]
authorJason Merrill <jason@redhat.com>
Thu, 17 Feb 2022 05:04:21 +0000 (00:04 -0500)
committerJason Merrill <jason@redhat.com>
Thu, 17 Feb 2022 22:50:59 +0000 (17:50 -0500)
commit2c9b7077b72529fbbe896212a0088bff6025c5e7
treec84aba9d3039be7e36d91f78bac3246369748514
parent1b71bc7c8b18bd1b22debfde155f175fd1654942
c++: inlining explicit instantiations [PR104539]

The PR10968 fix cleared DECL_COMDAT to force output of explicit
instantiations.  Then the PR59469 fix added a call to mark_needed, after
which we no longer need to clear DECL_COMDAT, and leaving it set allows us
to inline explicit instantiations without worrying about symbol
interposition.

I suppose there's an argument to be made that an explicit instantiation
declaration (extern template) should clear DECL_COMDAT, since that suggests
that there will be only a single instantiation somewhere that could be
subject to interposition, but that doesn't change the 'inline' semantics,
and it seems cleaner to treat template instantiations uniformly.

PR c++/104539

gcc/cp/ChangeLog:

* pt.cc (mark_decl_instantiated): Don't clear DECL_COMDAT.

gcc/testsuite/ChangeLog:

* g++.dg/ipa/inline-4.C: New test.
gcc/cp/pt.cc
gcc/testsuite/g++.dg/ipa/inline-4.C [new file with mode: 0644]