drm/amd/display: don't clean-up bottom pipe plane_state
authorShirish S <shirish.s@amd.com>
Tue, 26 Sep 2017 06:56:41 +0000 (12:26 +0530)
committerAlex Deucher <alexander.deucher@amd.com>
Tue, 26 Sep 2017 22:17:44 +0000 (18:17 -0400)
commit2c8f195adf21430e4e8bbd13942826ccf8fa225c
treec6527a541d346cd8d65caedec6ea690d290ab848
parent4a6cee2ca142615970fa3334191e992e7fb51159
drm/amd/display: don't clean-up bottom pipe plane_state

In the scenario of setting underlay, dc_validate_global_state()
is called after constructing the context with all
relevant bottom_pipe related configurations in dm_update_planes_state().

Currently, in dc_validate_global_state(), without checking for bottom_pipe's
existence, the pipe_ctx structure is initialised to 0, hence
nullyfying the plane_state of bottom_pipe which shall be accessed
in populate_initial_data() called from bw_calcs().

Due to this null pointer access kernel panics and leads to reboot
when underlay is tried to set.

This patch fixes the issue by no longer clearing the top_pipe. This
workaround is no longer required.

Signed-off-by: Shirish S <shirish.s@amd.com>
Reviewed-by: Harry Wentland <harry.wentland@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/dc/core/dc_resource.c