hwmon: (acpi_power_meter) Use acpi_bus_get_acpi_device()
authorRafael J. Wysocki <rafael.j.wysocki@intel.com>
Wed, 13 Oct 2021 16:04:09 +0000 (18:04 +0200)
committerGuenter Roeck <linux@roeck-us.net>
Sun, 17 Oct 2021 05:41:25 +0000 (22:41 -0700)
commit2c59a32d12201b4aeaef5c0cc04698670e164dc3
tree3a8c28b92063a792eda33a41df3df2c73ee21330
parentb1986c8e31a3e5f119a52aab50234fc65cf01f30
hwmon: (acpi_power_meter) Use acpi_bus_get_acpi_device()

In read_domain_devices(), acpi_bus_get_device() is called to obtain
the ACPI device object attached to the given ACPI handle and
subsequently that object is passed to get_device() for reference
counting, but there is a window between the acpi_bus_get_device()
and get_device() calls in which the ACPI device object in question
may go away.

To address this issue, make read_domain_devices() use
acpi_bus_get_acpi_device() to reference count and return the given
ACPI device object in one go and export that function to modules.

While at it, also make read_domain_devices() and
remove_domain_devices() use acpi_dev_put() instead of calling
put_device() directly on the ACPI device objects returned by
acpi_bus_get_acpi_device().

Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/11871063.O9o76ZdvQC@kreacher
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
drivers/acpi/scan.c
drivers/hwmon/acpi_power_meter.c