Revert "usb: misc: ehset: Workaround for "special" hubs"
authorJohan Hovold <johan@kernel.org>
Thu, 7 Oct 2021 09:06:01 +0000 (11:06 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 7 Oct 2021 10:48:54 +0000 (12:48 +0200)
commit2c52ad743fee10c0815db77a4e47f2416d407123
treef9a3c74d7847d86a83df66595dc5f7f2041fa26a
parentf3351eca1fb16abc4c33392a980e1ec1a6f6aa59
Revert "usb: misc: ehset: Workaround for "special" hubs"

This reverts commit ce3e90d5a0cdbcb2ddebbf9e4363e59fa779ad3a.

The commit in question added list of quirky hubs, but the match
implementation clearly hasn't been tested at all.

First, hub_udev->dev.parent does not represent a USB interface so using
to_usb_interface() makes no sense and we'd be passing a random pointer
to usb_match_id().

Second, if hub_udev is a root hub it doesn't even even represent a USB
device.

Signed-off-by: Johan Hovold <johan@kernel.org>
Fixes: ce3e90d5a0cd ("usb: misc: ehset: Workaround for "special" hubs")
Cc: Razvan Heghedus <heghedus.razvan@gmail.com>
Link: https://lore.kernel.org/r/20211007090601.19156-1-johan@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/misc/ehset.c