rtc: handle errors correctly in rtc_irq_set_state()
authorThomas Gleixner <tglx@linutronix.de>
Tue, 26 Jul 2011 23:08:18 +0000 (16:08 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Tue, 26 Jul 2011 23:49:41 +0000 (16:49 -0700)
commit2c4f57d12df7696d65b0247bfd57fd082a7719e6
tree920060fbbbc18643711e61526be4040e57118145
parentb45d59fb92f60c9c3cda01355d42b907b863e47a
rtc: handle errors correctly in rtc_irq_set_state()

The code checks the correctness of the parameters, but unconditionally
arms/disarms the hrtimer.

The result is that a random task might arm/disarm rtc timer and surprise
the real owner by either generating events or by stopping them.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: John Stultz <john.stultz@linaro.org>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Ben Greear <greearb@candelatech.com>
Cc: <stable@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/rtc/interface.c