gdbus: Check for NULL DBusPendingCall in g_dbus_send_message_with_reply
authorSzymon Janc <szymon.janc@tieto.com>
Thu, 26 Sep 2013 08:02:34 +0000 (10:02 +0200)
committerMarcel Holtmann <marcel@holtmann.org>
Mon, 14 Oct 2013 13:08:22 +0000 (06:08 -0700)
commit2be018f11e031c2ba41c4af82c9de63c7b3053c5
treef8bbc58b387de10bd0a6fd92701487f0b94144de
parent50b9e60e62c5b544f42621b49fa8fedc8bf86735
gdbus: Check for NULL DBusPendingCall in g_dbus_send_message_with_reply

"Warning: if the connection is disconnected or you try to send Unix file
descriptors on a connection that does not support them, the
DBusPendingCall will be set to NULL, so be careful with this."

Check this in g_dbus_send_message_with_reply so that callers don't need
to double check for NULL if g_dbus_send_message_with_reply returned
TRUE.

This also fix crash if passing FD over D-Bus is blocked e.g. by SELinux
policy.

bluetoothd[1894]: profiles/audio/avdtp.c:session_cb()
bluetoothd[1894]: profiles/audio/avdtp.c:avdtp_parse_cmd() Received
    SET_CONFIGURATION_CMD
bluetoothd[1894]: profiles/audio/a2dp.c:endpoint_setconf_ind() Source
    0x6c5000: Set_Configuration_Ind
bluetoothd[1894]: profiles/audio/avdtp.c:avdtp_ref() 0x6df360: ref=1
bluetoothd[1894]: profiles/audio/a2dp.c:setup_ref() 0x6d32b0: ref=1
process 1894: arguments to dbus_pending_call_set_notify() were incorrect,
     assertion "pending != NULL" failed in file dbus-pending-call.c line
     636.
This is normally a bug in some application using the D-Bus library.
gdbus/object.c