extlinux: Avoid dereferencing a garbage pointer
authorMatt Fleming <matt.fleming@intel.com>
Fri, 2 Nov 2012 17:02:36 +0000 (17:02 +0000)
committerMatt Fleming <matt.fleming@intel.com>
Mon, 5 Nov 2012 08:29:58 +0000 (08:29 +0000)
commit2bc5ea50ca5f670c1101d7986a70adfc5cae8b48
tree58a2c9a5fd0ce35897c5bd3c41ff268c596f120e
parent967ee8a1ed49092ed2a6296936698a40b115a013
extlinux: Avoid dereferencing a garbage pointer

If opt.reset_adv is set the call to ext_read_adv() is skipped which
would have initialised 'filename'. This means that a pointer
containing random data from the stack is passed to ext_write_adv().

Just delete the opt.reset_adv logic since modify_adv() handles that
case anyway.

Reported-by: Frediano Ziglio <frediano.ziglio@citrix.com>
Signed-off-by: Matt Fleming <matt.fleming@intel.com>
extlinux/main.c