ext4: warn when dirtying page w/o buffers in data=journal mode
authorJan Kara <jack@suse.cz>
Thu, 10 Mar 2022 10:18:32 +0000 (11:18 +0100)
committerTheodore Ts'o <tytso@mit.edu>
Sun, 13 Mar 2022 02:02:18 +0000 (21:02 -0500)
commit2bb8dd401a4f96973d6a9de4218d7f01fbd497ee
tree1276facc1b00095ccf9c01f887583c846d5ab2ee
parent688b0d8536e0e937f608a93cb6909e14389a0c45
ext4: warn when dirtying page w/o buffers in data=journal mode

Recently I've got a report of BUG_ON trigerring during transaction
commit in ext4_journalled_writepage_callback() because we've spotted a
dirty page without buffers. Add WARN_ON_ONCE to
ext4_journalled_set_page_dirty() to catch the problematic condition
earlier where we have better chance of understanding which code path is
creating dirty data without preparing the page properly. Also update the
comment with current information when we are at it.

Signed-off-by: Jan Kara <jack@suse.cz>
Link: https://lore.kernel.org/r/20220310101832.5645-1-jack@suse.cz
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
fs/ext4/inode.c