mac80211: Fix clang warning about constant operand in logical operation
authorMatthias Kaehlcke <mka@chromium.org>
Thu, 6 Apr 2017 23:31:41 +0000 (16:31 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 8 Apr 2018 10:12:46 +0000 (12:12 +0200)
commit2bb306460188d3200e42e1431d24d19df4159505
tree02b1d71edde0b81ca8c13a61502f7b463b20d391
parent3e8f962da78c89b96c7ed718d77e35a1caf469da
mac80211: Fix clang warning about constant operand in logical operation

commit 93f56de259376d7e4fff2b2d104082e1fa66e237 upstream.

When clang detects a non-boolean constant in a logical operation it
generates a 'constant-logical-operand' warning. In
ieee80211_try_rate_control_ops_get() the result of strlen(<const str>)
is used in a logical operation, clang resolves the expression to an
(integer) constant at compile time when clang's builtin strlen function
is used.

Change the condition to check for strlen() > 0 to make the constant
operand boolean and thus avoid the warning.

Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Cc: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/mac80211/rate.c