drm/amd: fix some dead code in `gfx_v9_0_init_cp_compute_microcode`
authorMario Limonciello <mario.limonciello@amd.com>
Thu, 12 Jan 2023 22:37:01 +0000 (16:37 -0600)
committerAlex Deucher <alexander.deucher@amd.com>
Fri, 13 Jan 2023 19:58:04 +0000 (14:58 -0500)
commit2b89da46a77d2929c1b00af5eb6a07f3d95a931c
treee3c9afeba0f7f80972ddb3d6ba195ff40c5884c9
parentd144b40a4833db01712f887ff31388a37ec51926
drm/amd: fix some dead code in `gfx_v9_0_init_cp_compute_microcode`

Some dead code was introduced as part of utilizing the `amdgpu_ucode_*`
helpers. Adjust the control flow to make sure that firmware is released
in the appropriate error flows.

Reported-by: coverity-bot <keescook+coverity-bot@chromium.org>
Addresses-Coverity-ID: 1530548 ("Control flow issues")
Fixes: ec787deb2ddf ("drm/amd: Use `amdgpu_ucode_*` helpers for GFX9")
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c