[PATCH] Fix buddy list race that could lead to page lru list corruptions
authorNick Piggin <piggin@cyberone.com.au>
Mon, 10 Apr 2006 23:54:00 +0000 (16:54 -0700)
committerGreg Kroah-Hartman <gregkh@suse.de>
Mon, 17 Apr 2006 20:16:05 +0000 (13:16 -0700)
commit2b53303840e1a8f1c7d007d988e8f497248ca270
tree855c466c03ca32099ad6bb983833e4011e3f90a7
parentadd92b7ade7eb528b7df6153f8bc773f5e2a80f1
[PATCH] Fix buddy list race that could lead to page lru list corruptions

Rohit found an obscure bug causing buddy list corruption.

page_is_buddy is using a non-atomic test (PagePrivate && page_count == 0)
to determine whether or not a free page's buddy is itself free and in the
buddy lists.

Each of the conjuncts may be true at different times due to unrelated
conditions, so the non-atomic page_is_buddy test may find each conjunct to
be true even if they were not both true at the same time (ie. the page was
not on the buddy lists).

Signed-off-by: Martin Bligh <mbligh@google.com>
Signed-off-by: Rohit Seth <rohitseth@google.com>
Signed-off-by: Nick Piggin <npiggin@suse.de>
Signed-off-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
include/linux/mm.h
include/linux/page-flags.h
mm/page_alloc.c