Remove PDBFileBuilder::build() and related functions.
authorRui Ueyama <ruiu@google.com>
Tue, 22 Nov 2016 20:32:22 +0000 (20:32 +0000)
committerRui Ueyama <ruiu@google.com>
Tue, 22 Nov 2016 20:32:22 +0000 (20:32 +0000)
commit2b4ba04d57b35d638e15d71ec6d1e8622e1ea49a
treea7d5ce91d8efea030ccdf6dd1542043c83be5277
parente99e8d345c0bde318befd55cb5ce14d787f960f6
Remove PDBFileBuilder::build() and related functions.

PDBFileBuilder supports two different ways to create files.
One is PDBFileBuilder::commit. That function takes a filename
and write a result to the file. The other is PDBFileBuilder::build.
That returns a new PDBFile object.

This patch removes the latter because no one is using it and
in a real life situation we are very unlikely to need it.
Even if you need it, it'd be easy to write a new PDB to a memory
buffer and read it back.

Removing PDBFileBuilder::build enables us to remove other classes
build transitively.

Differential Revision: https://reviews.llvm.org/D26987

llvm-svn: 287697
llvm/include/llvm/DebugInfo/PDB/Raw/DbiStreamBuilder.h
llvm/include/llvm/DebugInfo/PDB/Raw/InfoStreamBuilder.h
llvm/include/llvm/DebugInfo/PDB/Raw/PDBFileBuilder.h
llvm/include/llvm/DebugInfo/PDB/Raw/TpiStreamBuilder.h
llvm/lib/DebugInfo/PDB/Raw/DbiStreamBuilder.cpp
llvm/lib/DebugInfo/PDB/Raw/InfoStreamBuilder.cpp
llvm/lib/DebugInfo/PDB/Raw/PDBFileBuilder.cpp
llvm/lib/DebugInfo/PDB/Raw/TpiStreamBuilder.cpp