staging: most: Replace all non-returning strlcpy with strscpy
authorAzeem Shaikh <azeemshaikh38@gmail.com>
Tue, 23 May 2023 02:16:40 +0000 (02:16 +0000)
committerKees Cook <keescook@chromium.org>
Thu, 1 Jun 2023 14:07:37 +0000 (07:07 -0700)
commit2af4aa3be58802cf00f834eeaad1243290bb1d4a
treea257051661049f7ecedd1f0e79a0c45597da2893
parentf4a0659f823e5a828ea2f45b4849ea8e2dd2984c
staging: most: Replace all non-returning strlcpy with strscpy

strlcpy() reads the entire source buffer first.
This read may exceed the destination size limit.
This is both inefficient and can lead to linear read
overflows if a source string is not NUL-terminated [1].
In an effort to remove strlcpy() completely [2], replace
strlcpy() here with strscpy().
No return values were used, so direct replacement is safe.

[1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy
[2] https://github.com/KSPP/linux/issues/89

Signed-off-by: Azeem Shaikh <azeemshaikh38@gmail.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Kees Cook <keescook@chromium.org>
Link: https://lore.kernel.org/r/20230523021640.2406585-1-azeemshaikh38@gmail.com
drivers/most/configfs.c