of: unittest: fix memory leak in attach_node_and_children
authorErhard Furtner <erhard_f@mailbox.org>
Tue, 26 Nov 2019 01:48:04 +0000 (02:48 +0100)
committerRob Herring <robh@kernel.org>
Tue, 26 Nov 2019 19:32:43 +0000 (12:32 -0700)
commit2aacace6dbbb6b6ce4e177e6c7ea901f389c0472
treead46497560cf29bd98698b72d1234e4074ac2a14
parent637392a8506a3a7dd24ab9094a14f7522adb73b4
of: unittest: fix memory leak in attach_node_and_children

In attach_node_and_children memory is allocated for full_name via
kasprintf. If the condition of the 1st if is not met the function
returns early without freeing the memory. Add a kfree() to fix that.

This has been detected with kmemleak:
Link: https://bugzilla.kernel.org/show_bug.cgi?id=205327
It looks like the leak was introduced by this commit:
Fixes: 5babefb7f7ab ("of: unittest: allow base devicetree to have symbol metadata")

Signed-off-by: Erhard Furtner <erhard_f@mailbox.org>
Reviewed-by: Michael Ellerman <mpe@ellerman.id.au>
Reviewed-by: Tyrel Datwyler <tyreld@linux.ibm.com>
Signed-off-by: Rob Herring <robh@kernel.org>
drivers/of/unittest.c