[llvm-objdump][COFF][NFC] Split format-specific interfaces; add namespace
authorHubert Tong <hubert.reinterpretcast@gmail.com>
Thu, 2 Apr 2020 22:17:52 +0000 (18:17 -0400)
committerHubert Tong <hubert.reinterpretcast@gmail.com>
Thu, 2 Apr 2020 22:42:13 +0000 (18:42 -0400)
commit2aab46ab0282b968de8593f916950d793a5a76d6
tree906a81a4f73cbc912264f19e39d39728a1a37baf
parentb94afc19ebccb77ad3140386d11920bd8885f2ed
[llvm-objdump][COFF][NFC] Split format-specific interfaces; add namespace

Summary:
This patch addresses, for the interfaces implemented by `COFFDump.cpp`,
multiple issues identified with the current structure of
`llvm-objdump.h` in the review of D72973.

This patch moves implementation details of the tool into an
`llvm::objdump` namespace for external linkage names, splits the
implementation details into separate headers for each implementation
file, and uses qualified names when declaring members of the
`llvm::objdump` namespace in place of leaving the namespace definition
open.

Reviewers: jhenderson, DiggerLin, jasonliu, daltenty, MaskRay

Reviewed By: jhenderson, MaskRay

Subscribers: MaskRay, rupprecht, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D77285
llvm/tools/llvm-objdump/COFFDump.cpp
llvm/tools/llvm-objdump/COFFDump.h [new file with mode: 0644]
llvm/tools/llvm-objdump/llvm-objdump.cpp
llvm/tools/llvm-objdump/llvm-objdump.h