[FileCheck] Make invalid prefix diagnostics more precise
authorJoel E. Denny <jdenny.ornl@gmail.com>
Mon, 11 May 2020 13:57:37 +0000 (09:57 -0400)
committerJoel E. Denny <jdenny.ornl@gmail.com>
Tue, 12 May 2020 01:11:58 +0000 (21:11 -0400)
commit2aa0217add1adbcabbc16e3ec44937e4277e117b
treef9bcf79c9d6dbe11cd313823896b80fbb183a0bf
parent1429e4c3992d2a5f90de5879773b6cf5a050cb5e
[FileCheck] Make invalid prefix diagnostics more precise

This will prove especially helpful after D79276, which introduces
comment prefixes.  Specifically, identifying whether there's a
uniqueness violation will be helpful as prefixes will be required to
be unique across both check prefixes and comment prefixes.

Also, remove a related comment about `cl::list` that no longer seems
relevant now that FileCheck is also a library.

Reviewed By: jhenderson, thopre

Differential Revision: https://reviews.llvm.org/D79375
llvm/lib/Support/FileCheck.cpp
llvm/test/FileCheck/validate-check-prefix.txt
llvm/utils/FileCheck/FileCheck.cpp