pinctrl: qcom: lpass lpi: use default pullup/strength values
authorJonathan Marek <jonathan@marek.ca>
Thu, 4 Mar 2021 19:48:16 +0000 (14:48 -0500)
committerLinus Walleij <linus.walleij@linaro.org>
Wed, 10 Mar 2021 23:13:07 +0000 (00:13 +0100)
commit2a9be38099e338f597c14d3cb851849b01db05f6
tree5c62f070f97329d0a4f311d30fb4c8ceceec1c81
parentc971af25cda94afe71617790826a86253e88eab0
pinctrl: qcom: lpass lpi: use default pullup/strength values

If these fields are not set in dts, the driver will use these variables
uninitialized to set the fields. Not only will it set garbage values for
these fields, but it can overflow into other fields and break those.

In the current sm8250 dts, the dmic01 entries do not have a pullup setting,
and might not work without this change.

Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Fixes: 6e261d1090d6 ("pinctrl: qcom: Add sm8250 lpass lpi pinctrl driver")
Signed-off-by: Jonathan Marek <jonathan@marek.ca>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Reviewed-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Link: https://lore.kernel.org/r/20210304194816.3843-1-jonathan@marek.ca
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/qcom/pinctrl-lpass-lpi.c