net: dsa: lantiq_gswip: fix and improve the unsupported interface error
authorMartin Blumenstingl <martin.blumenstingl@googlemail.com>
Sun, 7 Jun 2020 13:02:58 +0000 (15:02 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 24 Jun 2020 15:50:19 +0000 (17:50 +0200)
commit2a9b3e4667f5f57386a0c351142b252d8bf800b6
treeb5249b1c8d69e85fc20387cda142c5fc3dcca257
parent88bc3e06039035fcd63a0d52ed8625e8682b107a
net: dsa: lantiq_gswip: fix and improve the unsupported interface error

[ Upstream commit 4d3da2d8d91f66988a829a18a0ce59945e8ae4fb ]

While trying to use the lantiq_gswip driver on one of my boards I made
a mistake when specifying the phy-mode (because the out-of-tree driver
wants phy-mode "gmii" or "mii" for the internal PHYs). In this case the
following error is printed multiple times:
  Unsupported interface: 3

While it gives at least a hint at what may be wrong it is not very user
friendly. Print the human readable phy-mode and also which port is
configured incorrectly (this hardware supports ports 0..6) to improve
the cases where someone made a mistake.

Fixes: 14fceff4771e51 ("net: dsa: Add Lantiq / Intel DSA driver for vrx200")
Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Acked-by: Hauke Mehrtens <hauke@hauke-m.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/dsa/lantiq_gswip.c