Don't use the QRegExp methods that modify the object [QtTest]
authorThiago Macieira <thiago.macieira@intel.com>
Fri, 20 Apr 2012 12:59:30 +0000 (14:59 +0200)
committerQt by Nokia <qt-info@nokia.com>
Tue, 24 Apr 2012 14:38:38 +0000 (16:38 +0200)
commit2a683c1f14897a04886ba1ad3df44b17d98ce8be
tree8a0d636e5e82b3fec8d1afeda74e6fac004c8662
parent29d2aad30a47009e5b756a608dc9366900caf71f
Don't use the QRegExp methods that modify the object [QtTest]

QRegExp matching methods modify the object, which we don't want to. In
particular, when we receive a QRegExp from the user or we store in a
context that might require thread-safety, make sure we make a copy
before using it.

QRegularExpression has no such shortcoming.

Task-number: QTBUG-25064
Change-Id: I7c5f5ebf4521c32337c9ea9aeeef50e1e8690bf8
Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
Reviewed-by: Jason McDonald <jason.mcdonald@nokia.com>
src/testlib/qbenchmarkvalgrind.cpp