ALSA: usb-audio: fix use after free in usb_audio_disconnect
authorPavel Skripkin <paskripkin@gmail.com>
Mon, 8 Mar 2021 22:30:57 +0000 (01:30 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 17 Mar 2021 16:06:27 +0000 (17:06 +0100)
commit29bc89c8b48dd1bfd7b1f55143b5d75d599e2a12
tree78d4021604fb30b763ff7a0fbf7cc5a2c5e75ef5
parentd2fdcc82d8661d8d29002e628f9d281f056942e7
ALSA: usb-audio: fix use after free in usb_audio_disconnect

commit c5aa956eaeb05fe87e33433d7fd9f5e4d23c7416 upstream.

The problem was in wrong "if" placement. chip->quirk_type is freed
in snd_card_free_when_closed(), but inside if statement it's accesed.

Fixes: 9799110825db ("ALSA: usb-audio: Disable USB autosuspend properly in setup_disable_autosuspend()")
Signed-off-by: Pavel Skripkin <paskripkin@gmail.com>
Cc: <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/16da19126ff461e5e64a9aec648cce28fb8ed73e.1615242183.git.paskripkin@gmail.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
sound/usb/card.c