[Target] Remove Process::GetCPPLanguageRuntime
authorAlex Langford <apl@fb.com>
Tue, 4 Jun 2019 20:14:33 +0000 (20:14 +0000)
committerAlex Langford <apl@fb.com>
Tue, 4 Jun 2019 20:14:33 +0000 (20:14 +0000)
commit29975a2a5d050d1c6a7220844efe8706d1376eb4
tree2335d25d4e4f2a6d100e36c999ba56b732c57da8
parenta03e2b25abfac72d2415edfef8a81ed127a95ca4
[Target] Remove Process::GetCPPLanguageRuntime

Summary:
I want to remove this method because I think that Process should be
language agnostic, or at least, not have knowledge about specific language
runtimes. There is "GetLanguageRuntime()" which should be used instead. If the
caller a CPPLanguageRuntime, they should cast it as needed. Ideally, this
should only happen in plugins that need C++ specific knowledge.

The next step I would like to do is remove "GetObjCLanguageRuntime()" as well.
There are a lot more instances of that function being used, so I wanted to
upload this one first to get the general reception to this idea.

Reviewers: compnerd, davide, JDevlieghere, jingham, clayborg, labath, aprantl

Subscribers: lldb-commits

Differential Revision: https://reviews.llvm.org/D62755

llvm-svn: 362544
lldb/include/lldb/Target/CPPLanguageRuntime.h
lldb/include/lldb/Target/Process.h
lldb/include/lldb/lldb-forward.h
lldb/source/Plugins/Language/CPlusPlus/LibCxx.cpp
lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntime.cpp
lldb/source/Target/Process.cpp