drm/gem: Properly annotate WW context on drm_gem_lock_reservations() error
authorDmitry Osipenko <dmitry.osipenko@collabora.com>
Thu, 30 Jun 2022 20:04:04 +0000 (23:04 +0300)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Tue, 9 Aug 2022 16:43:28 +0000 (18:43 +0200)
commit2939deac1fa220bc82b89235f146df1d9b52e876
tree1d98f32b7cc2b0fca0bd8c9cc36b483309d684aa
parentdf4aaf015775221dde8a51ee09edb919981f091e
drm/gem: Properly annotate WW context on drm_gem_lock_reservations() error

Use ww_acquire_fini() in the error code paths. Otherwise lockdep
thinks that lock is held when lock's memory is freed after the
drm_gem_lock_reservations() error. The ww_acquire_context needs to be
annotated as "released", which fixes the noisy "WARNING: held lock freed!"
splat of VirtIO-GPU driver with CONFIG_DEBUG_MUTEXES=y and enabled lockdep.

Cc: stable@vger.kernel.org
Fixes: 7edc3e3b975b5 ("drm: Add helpers for locking an array of BO reservations.")
Reviewed-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: https://patchwork.freedesktop.org/patch/msgid/20220630200405.1883897-2-dmitry.osipenko@collabora.com
drivers/gpu/drm/drm_gem.c