wifi: rtw88: Use non-atomic sta iterator in rtw_ra_mask_info_update()
authorMartin Blumenstingl <martin.blumenstingl@googlemail.com>
Sun, 8 Jan 2023 21:13:24 +0000 (22:13 +0100)
committerKalle Valo <kvalo@kernel.org>
Mon, 16 Jan 2023 16:27:44 +0000 (18:27 +0200)
commit2931978cd74f4a643deeea5b211523001d95aa44
tree0200dde1b36c8313eaf25be3730c535b9554a9b0
parent313f6dc7c5ed723d0c5691553eff4c0090f16bb8
wifi: rtw88: Use non-atomic sta iterator in rtw_ra_mask_info_update()

USB and (upcoming) SDIO support may sleep in the read/write handlers.
Use non-atomic rtw_iterate_stas() in rtw_ra_mask_info_update() because
the iterator function rtw_ra_mask_info_update_iter() needs to read and
write registers from within rtw_update_sta_info(). Using the non-atomic
iterator ensures that we can sleep during USB and SDIO register reads
and writes. This fixes "scheduling while atomic" or "Voluntary context
switch within RCU read-side critical section!" warnings as seen by SDIO
card users (but it also affects USB cards).

Fixes: 78d5bf925f30 ("wifi: rtw88: iterate over vif/sta list non-atomically")
Suggested-by: Ping-Ke Shih <pkshih@realtek.com>
Reviewed-by: Ping-Ke Shih <pkshih@realtek.com>
Tested-by: Sascha Hauer <s.hauer@pengutronix.de>
Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://lore.kernel.org/r/20230108211324.442823-4-martin.blumenstingl@googlemail.com
drivers/net/wireless/realtek/rtw88/mac80211.c