mptcp: fix data stream corruption
authorPaolo Abeni <pabeni@redhat.com>
Tue, 11 May 2021 17:13:51 +0000 (19:13 +0200)
committerDavid S. Miller <davem@davemloft.net>
Tue, 11 May 2021 23:19:17 +0000 (16:19 -0700)
commit29249eac5225429b898f278230a6ca2baa1ae154
treeda66634d5393a645fe2279d0e0a75c022304ee87
parentdf6f8237036938d48b7705681c170566c00593fa
mptcp: fix data stream corruption

Maxim reported several issues when forcing a TCP transparent proxy
to use the MPTCP protocol for the inbound connections. He also
provided a clean reproducer.

The problem boils down to 'mptcp_frag_can_collapse_to()' assuming
that only MPTCP will use the given page_frag.

If others - e.g. the plain TCP protocol - allocate page fragments,
we can end-up re-using already allocated memory for mptcp_data_frag.

Fix the issue ensuring that the to-be-expanded data fragment is
located at the current page frag end.

v1 -> v2:
 - added missing fixes tag (Mat)

Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/178
Reported-and-tested-by: Maxim Galaganov <max@internet.ru>
Fixes: 18b683bff89d ("mptcp: queue data for mptcp level retransmission")
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/mptcp/protocol.c